refactor: use builder pattern to improve readability of big functions #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is cool: https://github.com/tree-sitter/tree-sitter! |
suchapalaver
approved these changes
Feb 28, 2025
Pull Request Test Coverage Report for Build 13589528985Details
💛 - Coveralls |
Veetaha
reviewed
Feb 28, 2025
| /// We use phantom data as a marker since it's | ||
| /// only used to define what methods are available | ||
| /// for each type of network | ||
| #[builder(default = PhantomData)] |
There was a problem hiding this comment.
I recommend using #[builder(skip)] for PhantomData fields to avoid generating setters for this field at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce more usages of
bonto improve the readability and usage of some big functions, and simplify a few test cases by defaulting to a common value.To help find functions that have a big arity (ie many arguments) I built a helper CLI that uses tree-sitter to query the project: https://github.com/TypeLevelConsoli/rust-arity-scan